Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: user-selectable columns for reaction variations table #2364

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

feat: user-selectable columns for reaction variations table #2364

wants to merge 16 commits into from

Conversation

JanCBrammer
Copy link
Collaborator

This PR addresses #2296.

Columns can be selected via the blue "Select columns" button

button

which opens a modal for column selection.

modal

Note that the column selection gets reset once the reaction details tab is re-mounted.
This will be fixed with an upcoming PR, which aims to persist the table layout (addressing #2363).

The corresponding documentation is over at https://www.chemotion.net/docs/eln/ui/details#variations-tab.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025

LCOV of commit d11eac1 during Continuous Integration #4558

Summary coverage rate:
  lines......: 67.0% (15494 of 23126 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

PiTrem added a commit that referenced this pull request Mar 6, 2025
@PiTrem
feat: user-selectable columns for reaction variations table #2364
85d6fc3
@JanCBrammer JanCBrammer force-pushed the reaction-variations-column-config branch from d11eac1 to d179e53 Compare March 6, 2025 14:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025

LCOV of commit d179e53 during Continuous Integration #4603

Summary coverage rate:
  lines......: 66.9% (15481 of 23124 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@JanCBrammer JanCBrammer force-pushed the reaction-variations-column-config branch from d179e53 to 60ceeec Compare March 7, 2025 12:57
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025

LCOV of commit 0b33558 during Continuous Integration #4609

Summary coverage rate:
  lines......: 66.9% (15478 of 23121 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

PiTrem added a commit that referenced this pull request Mar 11, 2025
@PiTrem
feat: user-selectable columns for reaction variations table #2364
1b6d764
PiTrem added a commit that referenced this pull request Mar 11, 2025
@PiTrem
feat: user-selectable columns for reaction variations table #2364
7c261d3
PiTrem added a commit that referenced this pull request Mar 12, 2025
@PiTrem
feat: user-selectable columns for reaction variations table #2364
fd636d2
PiTrem added a commit that referenced this pull request Mar 13, 2025
@PiTrem
feat: user-selectable columns for reaction variations table #2364
d2604be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StarmanMartin StarmanMartin Awaiting requested review from StarmanMartin

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JanCBrammer